Support ReplicateV2 - #868
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 60.84% 60.72% -0.13%
==========================================
Files 184 184
Lines 17167 17265 +98
==========================================
+ Hits 10446 10484 +38
- Misses 6721 6781 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
marked this pull request as ready for review
September 8, 2026 18:37
cthulhu-rider
requested review from
carpawell,
roman-khimov and
smallhive
as code owners
September 8, 2026 18:37
cthulhu-rider
force-pushed
the
replicate-v2
branch
from
September 9, 2026 13:26
dd84193 to
3b3f95a
Compare
Brought doc typo fix and slight improvement for unimplemented servers. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
From nspcc-dev/neofs-api@320387f. Brought ReplicateV2 object API. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Unleash new API capabilities. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
replicate-v2
branch
from
September 9, 2026 13:28
3b3f95a to
0ec6483
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The generated bindings match the linked API definition, and the custom encoding paths have focused tests.
Review details
Files not reviewed (27)
- proto/accounting/service.pb.go: Generated file
- proto/accounting/service_grpc.pb.go: Generated file
- proto/accounting/types.pb.go: Generated file
- proto/acl/types.pb.go: Generated file
- proto/audit/types.pb.go: Generated file
- proto/container/service.pb.go: Generated file
- proto/container/service_grpc.pb.go: Generated file
- proto/container/types.pb.go: Generated file
- proto/link/types.pb.go: Generated file
- proto/lock/types.pb.go: Generated file
- proto/netmap/service.pb.go: Generated file
- proto/netmap/service_grpc.pb.go: Generated file
- proto/netmap/types.pb.go: Generated file
- proto/object/service.pb.go: Generated file
- proto/object/service_grpc.pb.go: Generated file
- proto/object/types.pb.go: Generated file
- proto/refs/types.pb.go: Generated file
- proto/reputation/service.pb.go: Generated file
- proto/reputation/service_grpc.pb.go: Generated file
- proto/reputation/types.pb.go: Generated file
- proto/session/service.pb.go: Generated file
- proto/session/service_grpc.pb.go: Generated file
- proto/session/types.pb.go: Generated file
- proto/status/types.pb.go: Generated file
- proto/storagegroup/types.pb.go: Generated file
- proto/subnet/types.pb.go: Generated file
- proto/tombstone/types.pb.go: Generated file
- Files reviewed: 5/32 changed files
- Comments generated: 0 new
- Review effort level: Balanced
roman-khimov
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.